Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hypervisor param to shiftstack playbook execution #2596

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add hypervisor param to shiftstack playbook execution #2596

wants to merge 2 commits into from
+21 −1

Conversation

eurijon
Copy link
Contributor

@eurijon eurijon commented Dec 12, 2024 •
edited
Loading

For being able to resolve shift-on-stack apps endpoints (routes) hostnames from RHOSO pods it's required to add the DNS record entry in then dnsmasq service running on the hypervisor.

i.e.:

# cat /etc/cifmw-dnsmasq.d/addresses.conf 
address=/apps.ocp.openstack.lab/x.y.z.v
address=/apps.ostest.shiftstack.local/x.y.z.s      <<-----

It needs to be done after shift-on-stack cluster is installed as the installer is creating the floating IP for the apps endpoints, and the FIP is not known in advance.

For that purpose the cifmw_target_host param is passed so the playbook running on the shiftstackclient pod is able to reach the hypervisor.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eurijon
Copy link
Contributor Author

eurijon commented Dec 12, 2024

/test all

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bab06fb45064474d8f2429682f7aa61f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 23s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 42s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 42s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 55s
✔️ build-push-container-cifmw-client SUCCESS in 21m 57s
❌ cifmw-molecule-shiftstack FAILURE in 13m 38s

@pablintino
Add the hypervisors to the inventory
8462e7d 
For use cases like ShiftOnStack the deployment may need to tweak the
hypervisor.
We did not have a way to tell the deployment how to reach the hypervisor
so this commit exposes the hypervisor Ansible instance to each host
and creates a hypervisors group in the generated inventory.
@eurijon eurijon force-pushed the hypervisor-param branch 2 times, most recently from 2748acd to 0ce1031 Compare December 23, 2024 14:42
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4d84f8e902e146bda62b4bebfc5e39c4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 25s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 56s
❌ cifmw-pod-pre-commit FAILURE in 6m 08s
✔️ build-push-container-cifmw-client SUCCESS in 36m 21s
❌ cifmw-molecule-libvirt_manager FAILURE in 16m 03s
❌ cifmw-molecule-reproducer FAILURE in 9m 04s
❌ cifmw-molecule-shiftstack FAILURE in 12m 59s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/779b8b39503f4aa7bbcec4786a646ab5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 40s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 53s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 20m 07s
❌ cifmw-molecule-libvirt_manager FAILURE in 16m 09s
❌ cifmw-molecule-reproducer FAILURE in 9m 01s
❌ cifmw-molecule-shiftstack FAILURE in 15m 55s

@eurijon eurijon mentioned this pull request Dec 24, 2024
Open
@eurijon
Add hypervisor param to shiftstack playbook execution
cb8a31c 
For being able to resolve shift-on-stack apps endpoints (routes)
hostnames from RHOSO pods it's required to add the DNS record entry
in then dnsmasq service running on the hypervisor.
It needs to be done after shift-on-stack cluster is installed as
the installer is creating the floating IP for the apps endpoints,
and the FIP is not known in advance.
For that purpose the cifmw_target_host param is passed so the playbook
running on the shiftstackclient pod is able to reach the hypervisor.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7f750547375e455d9b6c220687a05a59

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 06s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 24s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 55s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 24s
✔️ build-push-container-cifmw-client SUCCESS in 37m 00s
❌ cifmw-molecule-libvirt_manager FAILURE in 17m 01s
❌ cifmw-molecule-reproducer FAILURE in 9m 31s
✔️ cifmw-molecule-shiftstack SUCCESS in 13m 06s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlobillo rlobillo Awaiting requested review from rlobillo rlobillo will be requested when the pull request is marked ready for review rlobillo is a code owner

@pablintino pablintino Awaiting requested review from pablintino pablintino will be requested when the pull request is marked ready for review pablintino is a code owner

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny will be requested when the pull request is marked ready for review lewisdenny is a code owner

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eurijon @pablintino